Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bike team pursuit benchmark (rewriting 1153) #1387

Merged
merged 21 commits into from
Mar 21, 2022
Merged

Add bike team pursuit benchmark (rewriting 1153) #1387

merged 21 commits into from
Mar 21, 2022

Conversation

teytaud
Copy link
Contributor

@teytaud teytaud commented Mar 15, 2022

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Motivation and Context / Related issue

See #1153

How Has This Been Tested (if it applies)

Checklist

  • The documentation is up-to-date with the changes I made.
  • I have read the CONTRIBUTING document and completed the CLA (see CLA).
  • All tests passed, and additional code has been covered with new tests.

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Mar 15, 2022
@teytaud teytaud requested a review from jrapin March 15, 2022 14:40
Copy link
Contributor

@jrapin jrapin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess the following still holds from the hold PR

  1. Women and MenTeamPursuit classes look like they could be factorized further, can you point out what differs? For now I am seeing a lot of redundant code, we that much redundancy I may stop providing support for this test case if I need to refactorize some part of ExperimentFunction or the parametrization (no plan yet), because repetitions make maintenance more complicated. -> let's merge as is I guess, but I'm concerned that this can eventually serve as example to other benchmarks which will be far from the quality standard of the others

  2. Can you a add a dummy test just to make sure the function works, independently of the benchmark, that could be something as simple as that:

@teytaud
Copy link
Contributor Author

teytaud commented Mar 17, 2022

I factorized quite a bit and added a simple test.

@teytaud
Copy link
Contributor Author

teytaud commented Mar 21, 2022

@ryankroon could we have your opinion here ?

Copy link
Contributor

@jrapin jrapin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rename the main public facing class to use pep8 convention (capitalized name).
All the others should use the same convention as well in a perfect world... but at the very very least the main one must absolutely.

When that's done, feel free to merge

nevergrad/functions/cycling/cycling.py Outdated Show resolved Hide resolved
nevergrad/functions/cycling/__init__.py Outdated Show resolved Hide resolved
nevergrad/benchmark/experiments.py Outdated Show resolved Hide resolved
nevergrad/benchmark/experiments.py Outdated Show resolved Hide resolved
@jrapin jrapin changed the title Bike: rewriting 1153 Add bike team pursuit benchmark (rewriting 1153) Mar 21, 2022
@teytaud teytaud merged commit 07f6ec0 into main Mar 21, 2022
@teytaud teytaud deleted the bikemain branch March 21, 2022 17:25
@ryankroon
Copy link
Contributor

@ryankroon could we have your opinion here ?

Hi @teytaud and @jrapin,
(A bit late now but..) I am happy with the code and all looks good.
Furthermore, I thank you for helping me and completing the final changes / factorising so that my work could be merged - I was struggling a bit with this before.
I also apologise for leaving this work in somewhat of a limbo... I always planned to come back to it at a later date, but I have been very busy the past few months with starting a new job among other commitments.
Overall, I'm glad the work has been merged and I hope the it becomes a good benchmark problem.
Thank you,
Ryan

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants