Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use try/finally in context manager #1383

Merged
merged 1 commit into from
Mar 14, 2022
Merged

Use try/finally in context manager #1383

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions nevergrad/parametrization/helpers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,11 +135,13 @@ def deterministic_sampling(parameter: core.Parameter) -> tp.Iterator[None]:
deterministic = [lay.deterministic for lay in int_layers]
for lay in int_layers:
lay.deterministic = True
yield
# sample and reset the previous behavior
parameter.value # pylint: disable=pointless-statement
for lay, det in zip(int_layers, deterministic):
lay.deterministic = det
try:
yield
finally:
# sample and reset the previous behavior
parameter.value # pylint: disable=pointless-statement
for lay, det in zip(int_layers, deterministic):
lay.deterministic = det


def _fully_bounded_layers(data: pdata.Data) -> tp.List[_datalayers.BoundLayer]:
Expand Down