-
Notifications
You must be signed in to change notification settings - Fork 356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add NLOPT as a solver #1340
Merged
Add NLOPT as a solver #1340
Changes from 14 commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
afa248b
nlopt
teytaud e52b9a0
nlopt
teytaud bdc0335
Update recastlib.py
teytaud 9e81af6
Update nevergrad/optimization/recastlib.py
teytaud 9a27656
Update nevergrad/optimization/recastlib.py
teytaud d3f088d
Update nevergrad/optimization/recastlib.py
teytaud 2229bce
Update dev.txt
teytaud fee36c8
Update bench.txt
teytaud 25df99d
deprecation_fix
teytaud 1208f93
Merge branch 'main' into nlopt
teytaud 72dedee
Merge branch 'main' of github.com:facebookresearch/nevergrad into nlopt
teytaud dc575c7
fix
teytaud 86bf12b
Merge branch 'main' of github.com:facebookresearch/nevergrad into nlopt
teytaud fa152b4
fix_disappointingly_ignoring_pb_in_bo_warnings
teytaud cb417d6
Update nevergrad/optimization/test_optimizerlib.py
teytaud e7da0a0
Merge branch 'main' into nlopt
teytaud a1aa13c
Update recastlib.py
teytaud 0b23356
Update nevergrad/optimization/test_optimizerlib.py
teytaud 554fc53
fix
teytaud File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
experimental variant? There are already way too many optimizer classes in optimizerlib
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NLOpt is well known and significantly different... maybe we should split optimizerlib, but we should stop moving essential things in experimental variants.
A split + cleaning of optimizerlib.py is a good idea.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not for moving essential things in experimental variants, but avoiding considering everything as essential, from a user point of view there can't be 120 essential things. And
NonObjectOptimizer(method="NLOPT")
already + is better documented, so way more essential.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, it should be more documented, so please add a docstring