Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Python Crop Simulation #1339

Open
wants to merge 204 commits into
base: main
Choose a base branch
from
Open

Adding Python Crop Simulation #1339

wants to merge 204 commits into from

Conversation

teytaud
Copy link
Contributor

@teytaud teytaud commented Jan 20, 2022

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Motivation and Context / Related issue

Crop is a fundamental problem for humans on this planet.
I've not used the full power of PCSE --- more to come.

How Has This Been Tested (if it applies)

Checklist

  • The documentation is up-to-date with the changes I made.
  • I have read the CONTRIBUTING document and completed the CLA (see CLA).
  • All tests passed, and additional code has been covered with new tests.

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Jan 20, 2022
@teytaud teytaud requested a review from jrapin January 20, 2022 16:54
nevergrad/functions/pcse/pcse.py Show resolved Hide resolved
Comment on lines +21 to +22
import yaml
import pandas as pd
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

standard imports should be on top, pcse can be kept inline to avoid issues

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

standard imports should be on top, pcse can be kept inline to avoid issues

Done.

# error = objfunc_calculator(defaults)
# print("Objective function value with default parameters (%s): %s" % (defaults, error))

import nevergrad as ng
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

on top

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

nevergrad/functions/pcse/test_pcse.py Outdated Show resolved Hide resolved
nevergrad/optimization/optimizerlib.py Outdated Show resolved Hide resolved
nevergrad/optimization/test_optimizerlib.py Outdated Show resolved Hide resolved
@jrapin
Copy link
Contributor

jrapin commented Jan 26, 2022

I guess the License is too restrictive here :s it's a bit borderline here since it's a benchmark and not an optimizer, but it safer to avoid adding any...

@teytaud
Copy link
Contributor Author

teytaud commented Feb 16, 2022

I guess the License is too restrictive here :s it's a bit borderline here since it's a benchmark and not an optimizer, but it safer to avoid adding any...

Would a wget in the code be ok ?

teytaud and others added 30 commits December 12, 2022 19:40
* irrigation_challenge

* flute

* fix

* Update __init__.py

* Update experiments.py

* fix

* fix

* fix

* fix

* fix

* fix

* fix

* fix

* fix_gym

* fix_gym

* fix_gym

* fix

* fix
* irrigation_challenge

* flute

* fix

* Update __init__.py

* Update experiments.py

* fix

* fix

* fix

* fix

* fix

* fix

* fix

* fix

* fix_gym

* fix_gym

* fix_gym

* fix

* fix
* fix

* Adding costs in dollars per kg for various crops, and weird operations by Lev distance (#1468)

* fix

* Support for choosing the year(s) in PCSE stuff (#1469)

* fix

* o

* fix
* fix

* fix

* fix

* o

* fix

* fix

* fix

* fix

* GZZfix

* fix

* black

* fix_tst_irrigation

* one_more_false
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants