Optimization methods specifically for RL #1273
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
jrapin
reviewed
Nov 4, 2021
Comment on lines
+2093
to
+2096
| MixDeterministicRL = ConfPortfolio(optimizers=[DiagonalCMA, PSO, GeneticDE]).set_name( | ||
| "MixDeterministicRL", register=True | ||
| ) | ||
| SpecialRL = Chaining([MixDeterministicRL, TBPSA], ["half"]).set_name("SpecialRL", register=True) |
There was a problem hiding this comment.
Do we need both?
Suggested change
| MixDeterministicRL = ConfPortfolio(optimizers=[DiagonalCMA, PSO, GeneticDE]).set_name( | |
| "MixDeterministicRL", register=True | |
| ) | |
| SpecialRL = Chaining([MixDeterministicRL, TBPSA], ["half"]).set_name("SpecialRL", register=True) | |
| SpecialRL = Chaining([ConfPortfolio(optimizers=[DiagonalCMA, PSO, GeneticDE]), TBPSA], ["half"]).set_name("SpecialRL", register=True) |
jrapin
reviewed
Nov 4, 2021
| @@ -2760,3 +2767,6 @@ def __init__( | |||
| base_optimizer: base.OptCls = NGOpt, | |||
| ) -> None: | |||
| super().__init__(_MSR, locals()) | |||
|
|
|||
|
|
|||
| NGOptRL = SpecialRL | |||
There was a problem hiding this comment.
I'd rather we keep one name only if possible, why have two names for now?
As usual, adding more names means more breaking changes down the roads, so I prefer being careful.
|
deprecated by #1303 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of changes
Motivation and Context / Related issue
Just because it looks like an excellent tool specifically for RL
How Has This Been Tested (if it applies)
Experiments on Open AI Gym and neurocontrol.
Checklist