Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Externalize subparameter calls and simplify Parameter copy #1043

Merged
merged 25 commits into from
Feb 10, 2021

Conversation

jrapin
Copy link
Contributor

@jrapin jrapin commented Feb 10, 2021

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Motivation and Context / Related issue

This untangles Dict from Parameter, by removing the assumption that all parameters have a _parameters field.
It adds a helper to deal with function propagation to subobjects.
It also simplifies the handling of copies, which now use a shallow copy and updates the required fields, so that it becomes way simpler for all sub-classes

How Has This Been Tested (if it applies)

Checklist

  • The documentation is up-to-date with the changes I made.
  • I have read the CONTRIBUTING document and completed the CLA (see CLA).
  • All tests passed, and additional code has been covered with new tests.

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Feb 10, 2021
@jrapin jrapin changed the title Traverser Externalize subparameter calls and simplify Parameter copy Feb 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Do not delete this pull request or issue due to inactivity. Difficulty: High Priority: High
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants