Make sure pruning does prune #1014
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
jrapin
changed the title
jrapin
changed the title
jrapin
commented
Jan 18, 2021
| @@ -6,7 +6,7 @@ | |||
| import pickle | |||
There was a problem hiding this comment.
changes to this files are unrelated, just a convention update since I stumbled on it in the process
jrapin
commented
Jan 18, 2021
| @@ -269,8 +275,9 @@ def __call__(self, archive: Archive[MultiValue]) -> Archive[MultiValue]: | |||
| new_archive.bytesdict = { | |||
| b: v | |||
| for b, v in archive.bytesdict.items() | |||
| if any(v.get_estimation(n) <= quantiles[n] for n in names) | |||
| } | |||
| if any(v.get_estimation(n) < quantiles[n] for n in names) | |||
There was a problem hiding this comment.
the strict comparison is the big change that make it work.
jrapin
commented
Jan 18, 2021
| @@ -13,4 +13,4 @@ | |||
| __all__ = ["optimizers", "families", "callbacks", "p", "typing"] | |||
|
|
|||
|
|
|||
| __version__ = "0.4.2.post5" | |||
| __version__ = "0.4.2.post6" | |||
There was a problem hiding this comment.
new version because this is very impactful
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of changes
Motivation and Context / Related issue
This may solve #1013
The issue came from repeated values which may not be pruned, making the pruning mechanism be called way too often
How Has This Been Tested (if it applies)
Added a test to make sure pruning was not called too often, in the constant return case (worst case scenario)
Checklist