Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] package configs in sdist package #488

Closed
wants to merge 2 commits into from
Closed

[fix] package configs in sdist package #488

wants to merge 2 commits into from

Conversation

ariwaranosai
Copy link
Contributor

add config in MANIFEST.in to package yaml in mmf/configs.

see #479

@facebook-github-bot
Copy link
Contributor

Hi @ariwaranosai!

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.

In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Aug 18, 2020
@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@vedanuj vedanuj changed the title package configs in sdist package [fix] package configs in sdist package Aug 18, 2020
@vedanuj vedanuj requested a review from apsdehal August 18, 2020 15:33
@vedanuj
Copy link
Contributor

vedanuj commented Aug 18, 2020

Thanks for the fix. Looks good to me. Will leave it for @apsdehal to approve.

Copy link
Contributor

@apsdehal apsdehal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this. We definitely need to find a better solution to config packaging. Left a comment. Fix that and we should be good to go.

MANIFEST.in Show resolved Hide resolved
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@apsdehal has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@apsdehal has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

facebook-github-bot pushed a commit that referenced this pull request Aug 19, 2020
Summary:
add config in MANIFEST.in to package yaml in mmf/configs.

see #479

Pull Request resolved: #488

Reviewed By: vedanuj

Differential Revision: D23202899

Pulled By: apsdehal

fbshipit-source-id: 6544e20e458c103912cdc9abbc4cf86d0b71ff73
@apsdehal
Copy link
Contributor

Thanks for the PR. This has now landed into the master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants