Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing MiniHacks obs space if include_alignment_blstats==False #85

Merged
merged 2 commits into from
Apr 20, 2023

Conversation

samvelyan
Copy link
Contributor

observation_space was being computed incorrectly when include_alignment_blstats=False was being passed to MiniHack environments, introduced in #77.

This PR makes sure that the observation_space is computed accurately.

>>> import gym, minihack
>>> env = gym.make("MiniHack-MultiRoom-N6-v0", include_alignment_blstats=False)
>>> env.observation_space["blstats"]
Box(-2147483648, 2147483647, (26,), int64)
>>> env = gym.make("MiniHack-MultiRoom-N6-v0", include_alignment_blstats=True)
>>> env.observation_space["blstats"]
Box(-2147483648, 2147483647, (27,), int64)

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 19, 2023
@github-actions github-actions bot added the core label Apr 19, 2023
@samvelyan samvelyan merged commit ec04693 into main Apr 20, 2023
@samvelyan samvelyan deleted the samvelyan/obs_space branch April 20, 2023 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. core
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants