Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Supporting gym version 0.21.0 #31

Merged
merged 3 commits into from
Nov 16, 2021
Merged

Supporting gym version 0.21.0 #31

merged 3 commits into from
Nov 16, 2021

Conversation

samvelyan
Copy link
Contributor

Associated issue: #29

This is also related to the same issue in NLE. Due to the recent update on the gym side, gym wraps environments with the OrderEnforcing wrapper by default. This breaks our tests and some functionality. Here we disable order enforcing for the environments registered in MiniHack.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 16, 2021
@github-actions github-actions bot added the envs Contributions to MiniHack environments label Nov 16, 2021
@samvelyan samvelyan changed the title Setting the order_enforce as False if gym.__version__ >=0.21 Supporting gym version 0.21.0 Nov 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. core envs Contributions to MiniHack environments
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants