Skip to content
This repository has been archived by the owner on Oct 31, 2023. It is now read-only.

Save full configuration in output dir #835

Merged
merged 7 commits into from
May 31, 2019

Conversation

miguelvr
Copy link
Contributor

In order to facilitate reproduction and deployment of models it is a good practice to save the exact training configuration together with the model weights.

In this PR the full config is dumped into the output directory with the name config.yml

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label May 29, 2019
Copy link
Contributor

@fmassa fmassa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

I have only one minor comment, then this is good to merge!

tools/train_net.py Outdated Show resolved Hide resolved
Copy link
Contributor

@fmassa fmassa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@fmassa fmassa merged commit 7338be2 into facebookresearch:master May 31, 2019
Lyears pushed a commit to Lyears/maskrcnn-benchmark that referenced this pull request Jun 28, 2020
* Merge branch 'master' of /home/braincreator/projects/maskrcnn-benchmark with conflicts.

* update Dockerfile

* save config in output dir

* replace string format with os.path.join
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants