-
Notifications
You must be signed in to change notification settings - Fork 2.5k
Conversation
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed. If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't have much experience with Docker, but this looks great to me, thanks a lot!
Could you add a note in the bottom of the INSTALL.md
file mentioning the docker installation as well?
Maybe with the details that you added in the comment of the PR?
Thanks a lot!
Sure thing! You're welcome, thanks for the awesome project! |
This looks great. Could you add one which does not use conda/miniconda as well? |
why would you want that? It makes no difference because you're in a docker container. I just used conda because I know it is the preferred method to install pytorch due to the MKL version. |
yea i dont think non-conda based Dockerfile is needed. |
If there's a way for one dockerfile to start from another dockerfile, we should use this as the base Dockerfile https://github.com/pytorch/pytorch/blob/master/docker/pytorch/Dockerfile |
You can start a docker from an image, not another dockerfile. If you have an image built and hosted on a dockerhub I would be able to do it. But I am seeing that pytorch's image is for CUDA 9.0 only. |
You can always paste the contents of the dockerfile you created at the end of the pytorch dockerfile that Soumith linked here. Not elegant but should work. |
@fmassa please check if those instructions are enough |
I think this looks good, but I'll let @soumith comment as well because I don't have much experience with Docker. |
The current Image would be built without NCCL which is needed for fast distributed training. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot!
* added Dockerfile * intructions for installation with docker * adds nccl to dockerfile * Update Dockerfile * Update INSTALL.md
Added Dockerfile to build with CUDA
Example build script with defaults (
CUDA_VERSION=9.0
,CUDNN_VERSION=7
):Example build script with other CUDA and CUDNN versions: