Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

searchpath tab completion #2426

Merged
merged 2 commits into from
Oct 25, 2022
Merged

searchpath tab completion #2426

merged 2 commits into from
Oct 25, 2022

Conversation

Jasha10
Copy link
Collaborator

@Jasha10 Jasha10 commented Oct 20, 2022

Two commits:

  • tab completion support for custom search path
  • refactoring config_loader_impl: extract function

The first commit addresses #2421 to allow tab completion discovery of when a custom search path is in use.
The second commit is a pure refactoring, extracting a function from ConfigLoaderImpl.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 20, 2022
@Jasha10 Jasha10 marked this pull request as draft October 20, 2022 06:26
@Jasha10 Jasha10 marked this pull request as ready for review October 24, 2022 23:02
@Jasha10 Jasha10 merged commit eca53a3 into facebookresearch:main Oct 25, 2022
@Jasha10 Jasha10 deleted the searchpath-tab-completion branch October 25, 2022 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Jasha10 @facebook-github-bot