-
-
Notifications
You must be signed in to change notification settings - Fork 629
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update from antlr-4.8 to antlr-4.9 #2192
Conversation
Use the latest 4.9 release (4.9.3) Addresses issue facebookresearch#2155
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Jasha10 I don't know how valid my change to test_instantiate is TBH.
Note without that, omegaconf is throwing from a clause adjusted in omry/omegaconf#911
however I can't see how that specific change is at issue here, as it only seems to be a naming change
It looks like the CI failure happened when OmegaConf's
I don't think setting |
I'm confused because the PR omry/omegaconf#911 was supposed to be a pure refactoring without any behavior change. |
Yes this PR is just coincidental it seems. Reverting just that change, we're still left with the issue |
|
Right. I just now locally changed the pin to 2.2.0.dev2 (from April 13), and the following is fine:
So that narrows it down a lot |
I just did a git bisect to find that PR omry/omegaconf#909 is the culprit. |
I'll send in a PR to revert omry/omegaconf#909. |
This version of omegaconf now has a consistent requirement on antlr-4.9
Adjust as per the renamed interfaces in: omry/omegaconf#911
Use the latest 4.9 release (4.9.3)
Addresses issue #2155
Needs to follow omegaconf/pull/912 (master branch)