Fix flaky tests for TLS #824
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D35824204 |
Summary: Pull Request resolved: facebookresearch#824 X-link: facebookresearch/fbpcf#194 I think this is happening on stress runs because the helper function to generate certs just stores it in the same place (/tmp), so two parallel test runs could interfere with each other Reviewed By: chualynn Differential Revision: D35824204 fbshipit-source-id: 188aa45e1c05005ea8f31a3140a699d0cfc9a681
adshastri
added a commit
to adshastri/fbpcf
that referenced
this pull request
Apr 21, 2022
Summary: X-link: facebookresearch/fbpcs#824 Pull Request resolved: facebookresearch#194 I think this is happening on stress runs because the helper function to generate certs just stores it in the same place (/tmp), so two parallel test runs could interfere with each other Reviewed By: chualynn Differential Revision: D35824204 fbshipit-source-id: ce5aadd6af294dc0cd5874a51d1c510684ae0aac
adshastri
force-pushed
the
export-D35824204
branch
from
80eab24 to
0f7d4fb
Compare
|
This pull request was exported from Phabricator. Differential Revision: D35824204 |
facebook-github-bot
pushed a commit
to facebookresearch/fbpcf
that referenced
this pull request
Apr 21, 2022
Summary: X-link: facebookresearch/fbpcs#824 Pull Request resolved: #194 I think this is happening on stress runs because the helper function to generate certs just stores it in the same place (/tmp), so two parallel test runs could interfere with each other Reviewed By: chualynn Differential Revision: D35824204 fbshipit-source-id: b03bc0314076fdf6866a648e24f18712613dc15a
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: I think this is happening on stress runs because the helper function to generate certs just stores it in the same place (/tmp), so two parallel test runs could interfere with each other
Differential Revision: D35824204