Add benchmark for schedulers #164
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 29, 2022 15:47
Differential Revision: D35132668 fbshipit-source-id: 0e57940e21b00899687e951ed7f498611b27a88e
Summary: Looking for some feedback on this approach. The scheduler API has 40 methods, and trying to test each one individually would be overkill I think. Plus, the implementation for a lot of the gates is very similar. I figured the best thing to do would be to just create a bunch of dependent gates, that way we can test that the lazy scheduler properly batches things together more efficiently than the eager scheduler. If anyone has suggestions for more thorough things to test, LMK. Reviewed By: RuiyuZhu Differential Revision: D35162133 fbshipit-source-id: b29fb9fbd9b6da09e5cf34b23d4f359cbe3188c1
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D35162133 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Looking for some feedback on this approach.
The scheduler API has 40 methods, and trying to test each one individually would be overkill I think. Plus, the implementation for a lot of the gates is very similar.
I figured the best thing to do would be to just create a bunch of dependent gates, that way we can test that the lazy scheduler properly batches things together more efficiently than the eager scheduler.
If anyone has suggestions for more thorough things to test, LMK.
Reviewed By: RuiyuZhu
Differential Revision: D35162133