Skip to content

Commit

Permalink
Split the test cases to avoid timeout errors (#485)
Browse files Browse the repository at this point in the history
Summary:
Pull Request resolved: #485

We have seen a task T145020747 that some tests are flaky because they exceed the 600s limit. This diff splits the test cases to reduce the time needed to execute each test case.

Thanks adshastri for suggesting this fix. We will keep monitoring if this helps reduce flakiness and we will gradually apply it to other test cases

Reviewed By: adshastri

Differential Revision: D43200388

fbshipit-source-id: 993c06978a18b6b0126badd901872311edabda1f
  • Loading branch information
telgamal-1 authored and facebook-github-bot committed Feb 10, 2023
1 parent a1db227 commit 07487f1
Showing 1 changed file with 12 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -330,6 +330,10 @@ TEST(
1024,
128,
8));
}
TEST(
RcotBasedBidirectionObliviousTransferTest,
testBiDirectionOTIntegerWithExtenderBasedRcotPoweredByFerretExtenderPoweredByDummyMpcotAnd10LocalLinearMatrixMultipler) {
testRcotBasedBidirectionObliviousTransferForIntegers(
std::make_unique<ExtenderBasedRandomCorrelatedObliviousTransferFactory>(
std::make_unique<
Expand All @@ -352,7 +356,6 @@ TEST(
128,
8));
}

TEST(
RcotBasedBidirectionObliviousTransferTest,
testBiDirectionOTWithExtenderBasedRcotPoweredByFerretExtenderPoweredByMpcotWithDummySpcotAnd10LocalLinearMatrixMultipler) {
Expand Down Expand Up @@ -432,6 +435,10 @@ TEST(
ferret::kExtendedSize,
ferret::kBaseSize,
ferret::kWeight));
}
TEST(
RcotBasedBidirectionObliviousTransferTest,
testBiDirectionOTIntegerWithExtenderBasedRcotPoweredByFerretExtenderPoweredByMpcotWithRealSpcotAnd10LocalLinearMatrixMultipler) {
testRcotBasedBidirectionObliviousTransferForIntegers(
std::make_unique<ExtenderBasedRandomCorrelatedObliviousTransferFactory>(
std::make_unique<
Expand Down Expand Up @@ -483,6 +490,10 @@ TEST(
ferret::kExtendedSize,
ferret::kBaseSize,
ferret::kWeight));
}
TEST(
RcotBasedBidirectionObliviousTransferTest,
testBiDirectionOTIntegerWithBootstrappedExtenderBasedRcotPoweredByFerretExtenderPoweredByMpcotWithRealSpcotAnd10LocalLinearMatrixMultipler) {
testRcotBasedBidirectionObliviousTransferForIntegers(
std::make_unique<ExtenderBasedRandomCorrelatedObliviousTransferFactory>(
std::make_unique<tuple_generator::oblivious_transfer::
Expand Down

0 comments on commit 07487f1

Please sign in to comment.