Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix][make] add linker flags to tests/demo_ivfpq_indexing target #4

Merged
merged 1 commit into from
Feb 16, 2017

Conversation

blandinw
Copy link

before:

/usr/local/opt/llvm/bin/clang++ -o tests/demo_ivfpq_indexing -fPIC -m64 -Wall -g -O3 -msse4 -mpopcnt -fopenmp -Wno-sign-compare -Dnullptr=NULL -I/usr/local/opt/llvm/include -Doverride= -g -O3 tests/demo_i
vfpq_indexing.cpp libfaiss.a  -framework Accelerate
ld: library not found for -lomp
clang-3.9: error: linker command failed with exit code 1 (use -v to see invocation)
make: *** [tests/demo_ivfpq_indexing] Error 1

after:

λ make
/usr/local/opt/llvm/bin/clang++ -o tests/demo_ivfpq_indexing -fPIC -m64 -Wall -g -O3 -msse4 -mpopcnt -fopenmp -Wno-sign-compare -Dnullptr=NULL -I/usr/local/opt/llvm/include -Doverride= -g -O3 tests/demo_i
vfpq_indexing.cpp libfaiss.a -g -fPIC -fopenmp -L/usr/local/opt/llvm/lib -framework Accelerate
# success

@blandinw blandinw requested a review from mdouze February 15, 2017 19:49
@blandinw blandinw changed the title Wly fix demo ivfpq indexing [fix][make] add linker flags to tests/demo_ivfpq_indexing target Feb 15, 2017
@mdouze
Copy link
Contributor

mdouze commented Feb 15, 2017

Let me investigate a bit more. The flags are not needed for g++. Could you confirm that in your case they are needed for tests/demo_ivfpq_indexing but not tests/demo_sift1M?

@blandinw
Copy link
Author

I'm using clang 3.9 (from brew install llvm).
Maybe that's why? Will try again when I get to my computer

@mdouze
Copy link
Contributor

mdouze commented Feb 16, 2017

Ok I'll add to both tests/demo_ivfpq_indexing and tests/demo_sift1M

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants