-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update pinned numpy in github action #3974
base: main
Are you sure you want to change the base?
Conversation
@asadoughi I am surprised by how the seg fault in RAFT builds has suddenly arrived. My guess was a numpy version mismatch. The conda envs for RAFT 24.06 have numpy<2, which is why I pinned numpy=1.26.4. Upon running a valgrind on the torch tests, I see this:
which makes me wonder that downgrading torch might help. Please let me know if you have any suggestions. This exact same action was working earlier, right? If the github action was unchanged, it makes me wonder that this has to do something with version compatibility of some of the packages since the action does not pin versions for any of the packages. |
We can look into version pinning for all packages involved for the RAFT CI. Do you have a compatibility version of torch for RAFT 24.06? More generally, is there a published compatibility matrix for each version of RAFT? |
Summary: Related to testing in #3974 Based on comparing the logs of two runs: - failing: https://github.com/facebookresearch/faiss/actions/runs/11409771344/job/31751246207 - passing: https://github.com/facebookresearch/faiss/actions/runs/11368781432/job/31625550227 Pull Request resolved: #3980 Reviewed By: junjieqi Differential Revision: D64778154 Pulled By: asadoughi fbshipit-source-id: f4e53fed3850f3e0f391015c0349ee14da68330a
Pin numpy version to < 2 in github action