add no license lint to top of GPU files with both licenses #3965
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request was exported from Phabricator. Differential Revision: D64481766 |
|
This pull request was exported from Phabricator. Differential Revision: D64481766 |
mnorris11
pushed a commit
to mnorris11/faiss
that referenced
this pull request
Oct 16, 2024
…op of GPU files with both licenses (facebookresearch#3965) Summary: Pull Request resolved: facebookresearch#3965 This is the first diff in enabling linting. I wanted the diff which updates all files to be just the automated command and the .toml config files changes, so this diff is the preparation step. We need this because we get errors due to having both NVidia and FB license comment headers in the same files. See the errors in D64429711 under "linter-coverage-verification" signal. Context on linting: https://fb.workplace.com/groups/lintqa/posts/3762373340693743/?comment_id=3762915930639484&reply_comment_id=3763044163959994 Per OSS, we cannot remove the Nvidia notice: https://fb.workplace.com/groups/osssupport/posts/27179779734977284/?comment_id=27181801724775085&reply_comment_id=27181818148106776 Differential Revision: D64481766
mnorris11
force-pushed
the
export-D64481766
branch
from
111dd81
to
509ed3f
Compare
|
This pull request was exported from Phabricator. Differential Revision: D64481766 |
mnorris11
pushed a commit
to mnorris11/faiss
that referenced
this pull request
Oct 16, 2024
…op of GPU files with both licenses (facebookresearch#3965) Summary: Pull Request resolved: facebookresearch#3965 This is the first diff in enabling linting. I wanted the diff which updates all files to be just the automated command and the .toml config files changes, so this diff is a preparation step. We need this because we get errors due to having both NVidia and FB license comment headers in the same files. See the errors in D64429711 under "linter-coverage-verification" signal. Context on linting: https://fb.workplace.com/groups/lintqa/posts/3762373340693743/?comment_id=3762915930639484&reply_comment_id=3763044163959994 Per OSS, we cannot remove the Nvidia notice: https://fb.workplace.com/groups/osssupport/posts/27179779734977284/?comment_id=27181801724775085&reply_comment_id=27181818148106776 Differential Revision: D64481766
mnorris11
force-pushed
the
export-D64481766
branch
from
509ed3f
to
54081da
Compare
mnorris11
pushed a commit
to mnorris11/faiss
that referenced
this pull request
Oct 17, 2024
…op of GPU files with both licenses (facebookresearch#3965) Summary: This is the first diff in enabling linting. I wanted the diff which updates all files to be just the automated command and the .toml config files changes, so this diff is a preparation step. We need this because we get errors due to having both NVidia and FB license comment headers in the same files. See the errors in D64429711 under "linter-coverage-verification" signal. Context on linting: https://fb.workplace.com/groups/lintqa/posts/3762373340693743/?comment_id=3762915930639484&reply_comment_id=3763044163959994 Per OSS, we cannot remove the Nvidia notice: https://fb.workplace.com/groups/osssupport/posts/27179779734977284/?comment_id=27181801724775085&reply_comment_id=27181818148106776 Differential Revision: D64481766
mnorris11
force-pushed
the
export-D64481766
branch
from
54081da
to
0d54872
Compare
|
This pull request was exported from Phabricator. Differential Revision: D64481766 |
mnorris11
pushed a commit
to mnorris11/faiss
that referenced
this pull request
Oct 17, 2024
…op of GPU files with both licenses (facebookresearch#3965) Summary: This is the first diff in enabling linting. I wanted the diff which updates all files to be just the automated command and the .toml config files changes, so this diff is a preparation step. We need this because we get errors due to having both NVidia and FB license comment headers in the same files. See the errors in D64429711 under "linter-coverage-verification" signal. Context on linting: https://fb.workplace.com/groups/lintqa/posts/3762373340693743/?comment_id=3762915930639484&reply_comment_id=3763044163959994 Per OSS, we cannot remove the Nvidia notice: https://fb.workplace.com/groups/osssupport/posts/27179779734977284/?comment_id=27181801724775085&reply_comment_id=27181818148106776 Differential Revision: D64481766
mnorris11
force-pushed
the
export-D64481766
branch
from
0d54872
to
bfffd44
Compare
|
This pull request was exported from Phabricator. Differential Revision: D64481766 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D64481766 |
mnorris11
pushed a commit
to mnorris11/faiss
that referenced
this pull request
Oct 18, 2024
…op of GPU files with both licenses (facebookresearch#3965) Summary: Pull Request resolved: facebookresearch#3965 This is the first diff in enabling linting. I wanted the diff which updates all files to be just the automated command and the .toml config files changes, so this diff is a preparation step. We need this because we get errors due to having both NVidia and FB license comment headers in the same files. See the errors in D64429711 under "linter-coverage-verification" signal. Context on linting: https://fb.workplace.com/groups/lintqa/posts/3762373340693743/?comment_id=3762915930639484&reply_comment_id=3763044163959994 Per OSS, we cannot remove the Nvidia notice: https://fb.workplace.com/groups/osssupport/posts/27179779734977284/?comment_id=27181801724775085&reply_comment_id=27181818148106776 Differential Revision: D64481766
mnorris11
force-pushed
the
export-D64481766
branch
from
bfffd44
to
8dfe00d
Compare
…op of GPU files with both licenses (facebookresearch#3965) Summary: This is the first diff in enabling linting. I wanted the diff which updates all files to be just the automated command and the .toml config files changes, so this diff is a preparation step. We need this because we get errors due to having both NVidia and FB license comment headers in the same files. See the errors in D64429711 under "linter-coverage-verification" signal. Context on linting: https://fb.workplace.com/groups/lintqa/posts/3762373340693743/?comment_id=3762915930639484&reply_comment_id=3763044163959994 Per OSS, we cannot remove the Nvidia notice: https://fb.workplace.com/groups/osssupport/posts/27179779734977284/?comment_id=27181801724775085&reply_comment_id=27181818148106776 Differential Revision: D64481766
mnorris11
force-pushed
the
export-D64481766
branch
from
8dfe00d
to
7d72982
Compare
|
This pull request was exported from Phabricator. Differential Revision: D64481766 |
|
This pull request has been merged in fd6d784. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This is the first diff in enabling linting. I wanted the diff which updates all files to be just the automated command and the .toml config files changes, so this diff is the preparation step.
We need this because we get errors due to having both NVidia and FB license comment headers in the same files.
Context: https://fb.workplace.com/groups/lintqa/posts/3762373340693743/?comment_id=3762915930639484&reply_comment_id=3763044163959994
Differential Revision: D64481766