[ignore] refactor #3890
Open
[ignore] refactor #3890
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request was exported from Phabricator. Differential Revision: D63406173 |
|
This pull request was exported from Phabricator. Differential Revision: D63406173 |
mengdilin
added a commit
to mengdilin/faiss
that referenced
this pull request
Sep 25, 2024
Summary: Pull Request resolved: facebookresearch#3890 Differential Revision: D63406173
mengdilin
force-pushed
the
export-D63406173
branch
from
0680ada
to
a705a9c
Compare
|
This pull request was exported from Phabricator. Differential Revision: D63406173 |
mengdilin
added a commit
to mengdilin/faiss
that referenced
this pull request
Sep 25, 2024
Summary: Pull Request resolved: facebookresearch#3890 Differential Revision: D63406173
mengdilin
force-pushed
the
export-D63406173
branch
from
a705a9c
to
dd86d34
Compare
|
This pull request was exported from Phabricator. Differential Revision: D63406173 |
mengdilin
added a commit
to mengdilin/faiss
that referenced
this pull request
Sep 25, 2024
Summary: Pull Request resolved: facebookresearch#3890 Differential Revision: D63406173
mengdilin
force-pushed
the
export-D63406173
branch
from
dd86d34
to
9afb589
Compare
faiss/utils/simdlib_neon.h
Outdated
| @@ -972,6 +977,63 @@ struct simd8uint32 { | |||
| return ~(*this == other); | |||
| } | |||
|
|
|||
| // shift must be known at compile time | |||
| simd8uint32 operator<<(const int shift) const { | |||
| switch (shift) { | |||
There was a problem hiding this comment.
consider using vshlq_u32()
faiss/utils/simdlib_neon.h
Outdated
| @@ -1191,6 +1253,15 @@ struct simd8float32 { | |||
| std::string tostring() const { | |||
| return detail::simdlib::elements_to_string<float, 8u>("%g,", *this); | |||
| } | |||
|
|
|||
| float accumulate() const { | |||
| float32x4_t sum_0 = vpaddq_f32(data.val[0], data.val[0]); | |||
There was a problem hiding this comment.
consider using vaddvq_f32()
|
This pull request was exported from Phabricator. Differential Revision: D63406173 |
mengdilin
added a commit
to mengdilin/faiss
that referenced
this pull request
Sep 30, 2024
Summary: Pull Request resolved: facebookresearch#3890 Differential Revision: D63406173
mengdilin
force-pushed
the
export-D63406173
branch
from
9afb589
to
ac1bb02
Compare
|
This pull request was exported from Phabricator. Differential Revision: D63406173 |
mengdilin
added a commit
to mengdilin/faiss
that referenced
this pull request
Sep 30, 2024
Summary: Pull Request resolved: facebookresearch#3890 Differential Revision: D63406173
mengdilin
force-pushed
the
export-D63406173
branch
from
ac1bb02
to
02eca5f
Compare
|
This pull request was exported from Phabricator. Differential Revision: D63406173 |
mengdilin
added a commit
to mengdilin/faiss
that referenced
this pull request
Sep 30, 2024
Summary: Pull Request resolved: facebookresearch#3890 Differential Revision: D63406173
mengdilin
force-pushed
the
export-D63406173
branch
from
02eca5f
to
a0f938b
Compare
Summary: Pull Request resolved: facebookresearch#3890 Differential Revision: D63406173
|
This pull request was exported from Phabricator. Differential Revision: D63406173 |
mengdilin
force-pushed
the
export-D63406173
branch
from
a0f938b
to
06cc5df
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Differential Revision: D63406173