try refactor of L2 on simd8float32 #3794
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Pull Request resolved: facebookresearch#3613 As a demo for Mengdi. The steps to fully migrate to simdlib are: 1. change all function interfaces to use the generic simd8float32 and friends prototypes -- make sure it compiles on fbcode. 2. make sure it also compiles on ARM 3. see which functions can be mirgrated to only use the generic codepath 4. benchmark if the simd emulated path is competitve with the scalar (for platforms without specific SIMD support) The rationale here is that there are many SIMD instructions that are straightforward, like adding or subtracting registers, they can be put in common between implementations. The only code that may remain with arch-specific intrinsics is where they way of doing things is very different between AVX and NEON. Differential Revision: D59395882
Differential Revision: D60925434
|
This pull request was exported from Phabricator. Differential Revision: D60925434 |
|
@mengdilin please use a standard term |
mdouze
reviewed
Nov 21, 2024
| // bit shift by 16 -> uint32_t(v) << 16 | ||
|
|
||
| // load 8 as i32 and bit shift by 16 | ||
| simd8uint32 code_256i = load8_16bits_as_uint32(code, i); |
There was a problem hiding this comment.
maybe easier to load as simd32uint8 and cast to simd8uint32
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Differential Revision: D60925434