Back out "Add warning on adding nbits to LSH index factory" #3690
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Seems like this may not be necessary because it is the the expected behavior. See: facebookresearch#3687 (comment) Differential Revision: D60241747
|
This pull request was exported from Phabricator. Differential Revision: D60241747 |
|
This pull request has been merged in f2361a4. |
ketor
pushed a commit
to dingodb/faiss
that referenced
this pull request
Aug 20, 2024
…research#3690) Summary: Pull Request resolved: facebookresearch#3690 Seems like this may not be necessary because it is the the expected behavior. See: facebookresearch#3687 (comment) Reviewed By: asadoughi Differential Revision: D60241747 fbshipit-source-id: 7b8780fc4922a58c1975ae1b4343dc87e0eda0e1
aalekhpatel07
pushed a commit
to aalekhpatel07/faiss
that referenced
this pull request
Oct 17, 2024
…research#3690) Summary: Pull Request resolved: facebookresearch#3690 Seems like this may not be necessary because it is the the expected behavior. See: facebookresearch#3687 (comment) Reviewed By: asadoughi Differential Revision: D60241747 fbshipit-source-id: 7b8780fc4922a58c1975ae1b4343dc87e0eda0e1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Seems like this may not be necessary because it is the the expected behavior.
See: #3687 (comment)
Differential Revision: D60241747