remove unused code #3371
Closed
remove unused code #3371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request was exported from Phabricator. Differential Revision: D56274458 |
facebook-github-bot
force-pushed
the
export-D56274458
branch
from
228229d
to
d971512
Compare
|
This pull request was exported from Phabricator. Differential Revision: D56274458 |
facebook-github-bot
pushed a commit
that referenced
this pull request
Apr 19, 2024
Summary: This will never happen because N is fixed at compile time and the buffer is large enough. It is misleading to add error handling code for a case that will never happen. Reviewed By: kuarora Differential Revision: D56274458
facebook-github-bot
force-pushed
the
export-D56274458
branch
from
d971512
to
e86ac87
Compare
|
This pull request was exported from Phabricator. Differential Revision: D56274458 |
facebook-github-bot
pushed a commit
that referenced
this pull request
Apr 22, 2024
Summary: This will never happen because N is fixed at compile time and the buffer is large enough. It is misleading to add error handling code for a case that will never happen. Reviewed By: kuarora Differential Revision: D56274458
facebook-github-bot
force-pushed
the
export-D56274458
branch
from
e86ac87
to
0bd956f
Compare
|
This pull request was exported from Phabricator. Differential Revision: D56274458 |
Summary: This will never happen because N is fixed at compile time and the buffer is large enough. It is misleading to add error handling code for a case that will never happen. Reviewed By: kuarora Differential Revision: D56274458
junjieqi
force-pushed
the
export-D56274458
branch
from
0bd956f
to
98f7d6e
Compare
|
This pull request was exported from Phabricator. Differential Revision: D56274458 |
|
This pull request has been merged in 5893ab7. |
abhinavdangeti
pushed a commit
to blevesearch/faiss
that referenced
this pull request
Jul 12, 2024
Summary: Pull Request resolved: facebookresearch#3371 This will never happen because N is fixed at compile time and the buffer is large enough. It is misleading to add error handling code for a case that will never happen. Reviewed By: kuarora Differential Revision: D56274458 fbshipit-source-id: ca706f1223dbc97e69d5ac9750b277afa4df80a7
aalekhpatel07
pushed a commit
to aalekhpatel07/faiss
that referenced
this pull request
Oct 17, 2024
Summary: Pull Request resolved: facebookresearch#3371 This will never happen because N is fixed at compile time and the buffer is large enough. It is misleading to add error handling code for a case that will never happen. Reviewed By: kuarora Differential Revision: D56274458 fbshipit-source-id: ca706f1223dbc97e69d5ac9750b277afa4df80a7
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: This will never happen because N is fixed at compile time and the buffer is large enough. It is misleading to add error handling code for a case that will never happen.
Differential Revision: D56274458