Fix swig osx #3357
Closed
Fix swig osx #3357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 673f48a.
|
@junjieqi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@junjieqi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
mdouze
reviewed
Apr 24, 2024
faiss/python/swigfaiss.swig
Outdated
|
|
||
|
|
||
|
|
||
| /* |
There was a problem hiding this comment.
this is not necessary anymore I think
faiss/python/swigfaiss.swig
Outdated
| return SWIG_NewPointerObj(data, SWIGTYPE_p_unsigned_long, 0); | ||
| #else | ||
| return SWIG_NewPointerObj(data, SWIGTYPE_p_unsigned_long_long, 0); | ||
| #endif | ||
| } | ||
| if(PyArray_TYPE(ao) == NPY_INT64) { | ||
| #if (__SIZEOF_LONG__ == 8) | ||
| #if __SIZEOF_LONG__ == 8 && !(defined(__APPLE__) && defined(__MACH__)) |
There was a problem hiding this comment.
Here it is probably enough to test on
#ifndef __APPLE__
… fix_swig_osx merge .
|
@junjieqi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@junjieqi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
abhinavdangeti
pushed a commit
to blevesearch/faiss
that referenced
this pull request
Jul 12, 2024
Summary: The osx failed https://app.circleci.com/pipelines/github/facebookresearch/faiss/5698/workflows/4e029c32-8d8b-4db7-99e2-8e802aad6653/jobs/32701 Pull Request resolved: facebookresearch#3357 Reviewed By: kuarora Differential Revision: D56039739 Pulled By: junjieqi fbshipit-source-id: dd434a8817148364797eae39c09e0e1e9edbe858
aalekhpatel07
pushed a commit
to aalekhpatel07/faiss
that referenced
this pull request
Oct 17, 2024
Summary: The osx failed https://app.circleci.com/pipelines/github/facebookresearch/faiss/5698/workflows/4e029c32-8d8b-4db7-99e2-8e802aad6653/jobs/32701 Pull Request resolved: facebookresearch#3357 Reviewed By: kuarora Differential Revision: D56039739 Pulled By: junjieqi fbshipit-source-id: dd434a8817148364797eae39c09e0e1e9edbe858
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The osx failed
https://app.circleci.com/pipelines/github/facebookresearch/faiss/5698/workflows/4e029c32-8d8b-4db7-99e2-8e802aad6653/jobs/32701