-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert circleci workflows to github actions #3325
Convert circleci workflows to github actions #3325
Conversation
@junjieqi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Hi @robandpdx, I'm starting to look at this. Some early questions:
|
1d68d9b
to
4877294
Compare
215487a
to
ed4b32b
Compare
I have uncommented lines 57 and 66, putting the job dependencies back into place. I have also updated the runner label needed for the GPU runners to
Unfortunately, this is not as easily done with GitHub actions runners as with CircleCI
Communication via PR comments is good for me. If we need more, there is a slack channel @bigfootjon can help get you access to. |
Thanks @robandpdx ! |
Summary: This commit is the first in a series in an attempt to incrementally enable all jobs currenlty performed by CircleCI. It includes the main configuration files provided by GitHub team + 1 build. Original PR: #3325 Differential Revision: D56664307
Summary: This commit is the first in a series in an attempt to incrementally enable all jobs currenlty performed by CircleCI. It includes the main configuration files provided by GitHub team + 1 build. Original PR: #3325 Differential Revision: D56664619
Summary: This commit is the first in a series in an attempt to incrementally enable all jobs currenlty performed by CircleCI. It includes the main configuration files provided by GitHub team + 1 build. Original PR: #3325 Differential Revision: D56665402
Summary: This commit is the first in a series in an attempt to incrementally enable all jobs currenlty performed by CircleCI. It includes the main configuration files provided by GitHub team + 1 build. Original PR: #3325 Differential Revision: D56665616
Summary: This commit is the first in a series in an attempt to incrementally enable all jobs currenlty performed by CircleCI. It includes the main configuration files provided by GitHub team + 1 build. Original PR: facebookresearch#3325 Differential Revision: D56665616
Summary: This commit is the first in a series in an attempt to incrementally enable all jobs currenlty performed by CircleCI. It includes the main configuration files provided by GitHub team + 1 build. Original PR: facebookresearch#3325 Differential Revision: D56665616
Summary: This commit is the first in a series in an attempt to incrementally enable all jobs currenlty performed by CircleCI. It includes the main configuration files provided by GitHub team + 1 build. Original PR: #3325 Differential Revision: D56671582
Summary: This commit is the first in a series in an attempt to incrementally enable all jobs currenlty performed by CircleCI. It includes the main configuration files provided by GitHub team + 1 build. Original PR: #3325 Differential Revision: D56671582
Summary: This commit is the first in a series in an attempt to incrementally enable all jobs currenlty performed by CircleCI. It includes the main configuration files provided by GitHub team + 1 build. Original PR: #3325 Reviewed By: junjieqi Differential Revision: D56671582 fbshipit-source-id: c8a21cd69aabaf86134eb86753e90b1facf51bc3
Closing this as we have fixed all issues here and have ported all pipelines to GHA. Thanks for getting us started, Rob! |
Summary: This commit is the first in a series in an attempt to incrementally enable all jobs currenlty performed by CircleCI. It includes the main configuration files provided by GitHub team + 1 build. Original PR: facebookresearch#3325 Reviewed By: junjieqi Differential Revision: D56671582 fbshipit-source-id: c8a21cd69aabaf86134eb86753e90b1facf51bc3
Summary: This commit is the first in a series in an attempt to incrementally enable all jobs currenlty performed by CircleCI. It includes the main configuration files provided by GitHub team + 1 build. Original PR: facebookresearch#3325 Reviewed By: junjieqi Differential Revision: D56671582 fbshipit-source-id: c8a21cd69aabaf86134eb86753e90b1facf51bc3
This pull request converts the CircleCI workflows to GitHub actions workflows.
Notes
The dependencies between jobs seems to not be necessary, and I assume they exist only to limit spend on expensive jobs when less expensive jobs are failing. I have left the
needs: *
dependency definitions commented out in the workflow.Some jobs in the workflow require GPU runners. Some jobs in the workflow require ARM runners. I have configured the following runner groups.
Errors
I did my best to make all the jobs work, but lacking knowledge specific to this project makes it nearly impossible for me to get everything working. Someone with better knowledge of this project will need to address these error.
linux-x86_64-AVX512-cmake
job fails with the following error:Error
linux-x86_64-GPU-cmake
job fails with the following error:Error
windows-x86_64-conda
job fails with the following error:Error
linux-x86_64-GPU-packages-CUDA-11-4-4
job fails with the following error:Error
linux-x86_64-GPU-RAFT-packages-CUDA11-8-0
job fails with the following error:Error
linux-x86_64-GPU-packages-CUDA-12-1-1
job fails with the following error:Error
linux-x86_64-GPU-RAFT-packages-CUDA12-1-1
job fails with the following error:Error
windows-x86_64-packages
job fails with the following error:Error
OSX-arm64-packages
job fails with the following error:Error
Here is the latest workflow run in my fork.
https://fburl.com/workplace/f6mz6tmw