fix windows test #2775
Closed
fix windows test #2775
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request was exported from Phabricator. Differential Revision: D44210010 |
Summary: Pull Request resolved: facebookresearch#2775 Differential Revision: D44210010 fbshipit-source-id: 9f8490430b4f8659ff8b430edea23c2aeb4f6505
|
This pull request was exported from Phabricator. Differential Revision: D44210010 |
mdouze
force-pushed
the
export-D44210010
branch
from
ee10f6f to
7244549
Compare
|
This pull request has been merged in 0200d13. |
mdouze
added a commit
that referenced
this pull request
Mar 23, 2023
* fix windows test (#2775) Summary: Pull Request resolved: #2775 Reviewed By: algoriddle Differential Revision: D44210010 fbshipit-source-id: b9b620a4b0a874e09ee2f6082ff0f9463716fdf4 * faiss/utils/simdlib_avx2.h: avoid C++20 ambiguous overloaded operator (#2772) Summary: Pull Request resolved: #2772 Resolves errors from overloaded ambiguous operators: ``` faiss/utils/partitioning.cpp:283:34: error: ISO C++20 considers use of overloaded operator '==' (with operand types 'faiss::simd16uint16' and 'faiss::simd16uint16') to be ambiguous despite there being a unique best viable function [-Werror,-Wambiguous-reversed-operator] ``` Reviewed By: alexanderguzhva, meyering Differential Revision: D44186458 fbshipit-source-id: 0257fa0aaa4fe74c056bef751591f5f7e5357c9d * Fix Debug Build on aarch64 (#2768) Summary: related: #1916, #1979, #2009, #2013, #2195, #2210 After my PR #1815 had been merged `-DCMAKE_BUILD_TYPE=Debug` has been invalid on aarch64, and many people have been hit the problem. (sorry to inconvenience...) This PR fixes this. ### Details: Using the function pointers of intrinsics on run-time context causes the link errors. `-DCMAKE_BUILD_TYPE=Release` has been available because compiler optimizer can propagate and collapse the function pointers as constant. However, when the pointers doesn't collapsed the link errors occurred, so `-DCMAKE_BUILD_TYPE=Debug` has been unavailable. To prevent the link errors, I've replaced the function pointers of intrinsics on run-time context to on compile-time context explicitly. Pull Request resolved: #2768 Reviewed By: mdouze Differential Revision: D44296147 Pulled By: alexanderguzhva fbshipit-source-id: 81fa013c5e05a486b6b82cb85d76eeefdefca891 --------- Co-authored-by: Matthijs Douze <[email protected]> Co-authored-by: Jeff Palm <[email protected]> Co-authored-by: Y.Imaizumi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Differential Revision: D44210010