-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support SIMD Histogram Subroutines on aarch64 #2447
Conversation
The code looks good. |
Ah right, it is tested in |
@mdouze has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
I have trouble landing this, I may need to make a new PR |
@mdouze Is there any action that I should do, like closing this and making a new PR with a new branch, or something like that? |
If you could rebase this PR on the latest Faiss it would be helpful. Thansk. |
4c202db
to
5f35fe0
Compare
5f35fe0
to
26697ea
Compare
@mdouze Sorry, I thought it was rebased by the "Update branch" button until just now (the button had been MERGING |
@mdouze has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Thanks, second attempt... |
Currently SIMD histogram subroutines are written with
simdlib
and AVX2 intrinsics .This PR adds some functions to
simdlib
and removes AVX2 intrinsics from SIMD histogram subroutines, so faiss with this PR can execute histogram using ARM SIMD on aarch64.