One more refactoring in operator requirement fixer #1763
Conversation
Summary: I want to separate out the logic "try to make this node meet a requirement" and "give an error if you cannot"; this will make implementing matrix fill and broadcasting fixes easier. Reviewed By: AishwaryaSivaraman Differential Revision: D40495233 fbshipit-source-id: 3f35ed6c7c32d9b9e7aaa948c91d9abb6014314f
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D40495233 |
|
Hi @ericlippert! Thank you for your pull request. We require contributors to sign our Contributor License Agreement, and yours needs attention. You currently have a record in our system, but the CLA is no longer valid, and will need to be resubmitted. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
Summary: I want to separate out the logic "try to make this node meet a requirement" and "give an error if you cannot"; this will make implementing matrix fill and broadcasting fixes easier.
Reviewed By: AishwaryaSivaraman
Differential Revision: D40495233