This repository has been archived by the owner on Dec 18, 2023. It is now read-only.
minibmg: slightly reorganize tests so there is one directory for all minibmg tests. #1699
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
September 22, 2022 16:48
…earch#1689) Summary: Pull Request resolved: facebookresearch#1689 queries and observations are moved out of the nodes in the graph, and into separate data structures (a list of queried nodes, and a map from observed node to observed value). Differential Revision: https://internalfb.com/D39673068 fbshipit-source-id: 3436547817fc13c50dc9a82513abb33a0504498e
Summary: Pull Request resolved: facebookresearch#1694 We used to have two different expression DAG impleemntations: the graph nodes, and `Traced`, which was used for tracing and emitting code for automatic derivatives (AD). There was no reason for them to be separate, other than the fact that the traced version supports operator overloading. However, separating them required a number of small changes to make them similar enough to merge as a last step. This is that last step. This diff replaces the old traced implementation with a trivial wrapper around a node. Next will be a fluent graph factory that takes advantage of this. Differential Revision: https://internalfb.com/D39698758 fbshipit-source-id: 116eb64c53b50f50fe7a02850afc2b6568e03a04
Summary: Since node identifiers are not specific to a factory, we no longer need a global variable to keep track of which ones have been dispensed. Differential Revision: https://internalfb.com/D39738397 fbshipit-source-id: 1965df54ed2e896a0ecea4dc9569e80e4a45e1b4
Summary: Pull Request resolved: facebookresearch#1695 The topological sort used to iterate through the keys of the map giving the counts of the nodes to find the nodes with no predecessors. However, the iteration order of a map is not reliable. This diff makes the order deterministic. Differential Revision: https://internalfb.com/D39741135 fbshipit-source-id: 80667b0b75ed96b5e41c1735b25893bb89c65ed5
Summary: Pull Request resolved: facebookresearch#1693 The is a much more convenient way for creating graphs in C++. I think of it as the Bean Machine language implemented on top of C++. Differential Revision: https://internalfb.com/D39733618 fbshipit-source-id: cb71998a8e75ce9b4ff2e323991a322717ca2122
…minibmg tests. Summary: Move all of minibmg's tests into a single test directory. Differential Revision: D39754217 fbshipit-source-id: dc9fbde90cca460a36ae37c1c6afa356103f2854
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D39754217 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Move all of minibmg's tests into a single test directory.
Differential Revision: D39754217