Skip to content
This repository has been archived by the owner on Dec 18, 2023. It is now read-only.

Fix sdist builds by including headers #1309

Closed
wants to merge 2 commits into from

Conversation

feynmanliang
Copy link
Contributor

@feynmanliang feynmanliang commented Jan 14, 2022

Motivation

Fixes #1307

Changes proposed

Includes headers in sdist

Test Plan

See deploy.yml changes

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • The title of my pull request is a short description of the requested changes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 14, 2022
@feynmanliang feynmanliang changed the title [WIP] Fix sdist builds [WIP] Fix sdist builds by including headers Jan 14, 2022
@facebook-github-bot
Copy link
Contributor

@feynmanliang has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@feynmanliang feynmanliang changed the title [WIP] Fix sdist builds by including headers Fix sdist builds by including headers Jan 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error on pip install with source builds
2 participants