Skip to content

Commit

Permalink
Fix integration test (#338)
Browse files Browse the repository at this point in the history
Summary:
X-link: facebook/Ax#2282

Pull Request resolved: #338

Previously the integration test was failing due to not allowing unlimited trials on the last step. This is because the final step was copied from the exisiting botorch step (which contains transition criterion). If transition criterion exist on the step/node, we default to using those for determining the state of the node.

This fixes the test by manually unsetting the transition criterion arg for the aepsych strategy.py.

We also re-enable the test

Reviewed By: crasanders

Differential Revision: D54960088

fbshipit-source-id: e9c61f5ddefe45f5a9824c6dbd9068989a03bf72
  • Loading branch information
mgarrard authored and facebook-github-bot committed Mar 18, 2024
1 parent a8f56df commit d46b729
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 1 deletion.
1 change: 1 addition & 0 deletions aepsych/strategy.py
Original file line number Diff line number Diff line change
Expand Up @@ -530,6 +530,7 @@ def get_config_options(cls, config: Config, name: Optional[str] = None) -> Dict:
# Add an extra step at the end that we can `ask` endlessly.
final_step = copy(step)
final_step.completion_criteria = []
final_step._transition_criteria = []
final_step.num_trials = -1
steps.append(final_step)

Expand Down
1 change: 0 additions & 1 deletion tests/test_ax_integration.py
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@
from parameterized import parameterized_class


@unittest.skip("Test is flaky. Skipping for now.")
@parameterized_class(
("config_file", "should_ignore"),
[
Expand Down

0 comments on commit d46b729

Please sign in to comment.