Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default Review CLI interface / Add walkthrough in Custom React docs page #697

Merged
merged 5 commits into from
Mar 9, 2022

Conversation

pringshia
Copy link
Contributor

@pringshia pringshia commented Mar 9, 2022

Mostly docs as mentioned in the title.

Also updates the review CLI to ship with a default view when no local interface path is specified. This makes for a much smoother, batteries-loaded initial user experience.

# In practice this means you can now just run this (no REVIEW_APP_DIR arg):
mephisto review --db custom-react-tutorial-iterating --stdout --all

# instead of something like this
mephisto review review-app/build/ --db custom-react-tutorial-iterating --stdout --all

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 9, 2022
@pringshia pringshia changed the title Add review CLI information to the custom react docs Fill Review CLI section in Custom React docs page, add default UI support Mar 9, 2022
@codecov-commenter
Copy link

codecov-commenter commented Mar 9, 2022

Codecov Report

Merging #697 (31d37ce) into main (a6eed61) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #697   +/-   ##
=======================================
  Coverage   63.13%   63.13%           
=======================================
  Files          86       86           
  Lines        8295     8295           
=======================================
  Hits         5237     5237           
  Misses       3058     3058           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a6eed61...31d37ce. Read the comment docs.

@pringshia pringshia requested a review from JackUrb March 9, 2022 20:44
Copy link
Contributor

@JackUrb JackUrb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love the default reviewer, and thanks for updating the docs with it!

@pringshia pringshia merged commit 693026c into main Mar 9, 2022
@pringshia pringshia deleted the custom-react-docs branch March 9, 2022 21:57
@pringshia pringshia changed the title Fill Review CLI section in Custom React docs page, add default UI support Default Review CLI interface / Add cli docs in Custom React docs page Mar 11, 2022
@pringshia pringshia changed the title Default Review CLI interface / Add cli docs in Custom React docs page Default Review CLI interface / Add walkthrough in Custom React docs page Mar 11, 2022
@pringshia pringshia added this to the 🚀 Mephisto 1.0 milestone Mar 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants