Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Wire up mephisto-task and bootstrap-chat to yarn workspaces #659

Closed
wants to merge 3 commits into from

Conversation

pringshia
Copy link
Contributor

@pringshia pringshia commented Feb 11, 2022

Update: The functionality here has been absorbed into #655, will close this soon in favor of another PR that just focuses on the following:

  • add a test (added Dockerfile-frontend)
  • update docs

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Feb 11, 2022
@codecov-commenter
Copy link

codecov-commenter commented Feb 11, 2022

Codecov Report

Merging #659 (18471d1) into main (bf0517e) will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #659      +/-   ##
==========================================
- Coverage   63.14%   63.11%   -0.04%     
==========================================
  Files          86       86              
  Lines        8295     8295              
==========================================
- Hits         5238     5235       -3     
- Misses       3057     3060       +3     
Impacted Files Coverage Δ
...tractions/architects/channels/websocket_channel.py 79.06% <0.00%> (-3.49%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bf0517e...18471d1. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants