Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update heroku_architect.py #1025

Merged
merged 1 commit into from
Jun 21, 2023
Merged

Update heroku_architect.py #1025

merged 1 commit into from
Jun 21, 2023

Conversation

JackUrb
Copy link
Contributor

@JackUrb JackUrb commented Jun 20, 2023

Heroku has started adding a hash to the end of app name urls, so we must query for this from the CLI before returning.

Resolves #1024

Heroku has started adding a hash to the end of app name urls, so we must query for this from the CLI before returning
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 20, 2023
@codecov-commenter
Copy link

Codecov Report

Patch coverage: 20.00% and project coverage change: -0.01 ⚠️

Comparison is base (85ab7a5) 64.09% compared to head (9f1b73a) 64.09%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1025      +/-   ##
==========================================
- Coverage   64.09%   64.09%   -0.01%     
==========================================
  Files         108      108              
  Lines        9450     9452       +2     
==========================================
+ Hits         6057     6058       +1     
- Misses       3393     3394       +1     
Impacted Files Coverage Δ
...phisto/abstractions/architects/heroku_architect.py 35.48% <20.00%> (+0.13%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jayhuynh
Copy link

LGTM 🚢

@JackUrb JackUrb merged commit 32a0cd1 into main Jun 21, 2023
@JackUrb JackUrb deleted the heroku-domain-query branch June 21, 2023 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unhandled exception in socket server rejected WebSocket connection: HTTP 404
4 participants