-
Notifications
You must be signed in to change notification settings - Fork 5
DBEpisode import export #345
base: main
Are you sure you want to change the base?
Conversation
Just a general comment about the approach. It looks to me that here we are having a single file for each episode. Considering that most of our datasets have in order of thousands of episodes, I wonder if it makes too much of bottleneck for processing the files, for example when we have task teachers. |
We should definitely evaluate this. At the moment I need to be compressing the GraphEvent data, so after that is done maybe we can convert to JSONLs. This format is write-optimized for the Live deploy, so it's entirely reasonable for us to have a way to convert to a read-optimized format. |
… episode-import-export
Hi @JackUrb! Thank you for your pull request. We require contributors to sign our Contributor License Agreement, and yours needs attention. You currently have a record in our system, but the CLA is no longer valid, and will need to be resubmitted. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
Patch description
Adding import and export functionality to the
EpisodeDB
. Mostly just surrounds pulling from the current table after filtering on a group type, or loading all the contents of another initialized dataset into the current.Testing steps
Will merge after successfully prepping the MultiLIGHT dataset.