Skip to content
This repository has been archived by the owner on Oct 11, 2023. It is now read-only.

Worldbuilder task app refactor #294

Open
wants to merge 125 commits into
base: worldbuilder-task
Choose a base branch
from

Conversation

JustinPinero
Copy link
Contributor

  1. ### Overview
    Rewire the world builder app so that worlds can be generated by workers in a task. With in that world creation ensure workers can come back to the world creation and have plenty of time to work on the worlds they build.
    Steps toward rewiring:
  • Creating a "task router" that does not use the URL to navigate the various views within the builder app
  1. Current location and history will be stored in local storage
  2. This "virtual URL" can still hold id numbers for rooms, objects, and characters.
  3. The "Virtual URL" allows users to use a bread crumb to traverse their history so that they may move up as many layers as they so desire when editing nested nodes.
  • Focusing on a single world for the creation.
  1. This means removing all code and state referencing multiple worlds.
  2. The world draft will be saved in local storage using the agent ID as a key.
  3. It will be cleared after a successful submission.
  • Defining a "default" or "blank" world.
  1. This world will be the starting point for the task and contain no nodes but be properly formatted.
  2. It can be modified at anytime if we decide we want to give them a starting point.
  3. the base grid will populated this base world with a minimum number of room nodes so the worker can use the map to build.

Todos

  1. Successfully render world data from local storage.
  2. Tests Submitting a world using the task api. (Discuss of formatting as well)
  3. Remove all unused legacy code.

@JustinPinero JustinPinero requested a review from JackUrb May 19, 2022 19:38
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 19, 2022
@JackUrb JackUrb changed the base branch from main to worldbuilder-task May 20, 2022 15:11
JustinPinero and others added 29 commits July 15, 2022 16:47
…ering for new token generation in advanced characters page for worn and wielded objects
…esearch/LIGHT into worldbuilder-task-app-refactor
…esearch/LIGHT into worldbuilder-task-app-refactor
…esearch/LIGHT into worldbuilder-task-app-refactor
…esearch/LIGHT into worldbuilder-task-app-refactor
…esearch/LIGHT into worldbuilder-task-app-refactor
…esearch/LIGHT into worldbuilder-task-app-refactor
@facebook-github-bot
Copy link

Hi @JustinPinero!

Thank you for your pull request.

We require contributors to sign our Contributor License Agreement, and yours needs attention.

You currently have a record in our system, but the CLA is no longer valid, and will need to be resubmitted.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants