Skip to content
This repository has been archived by the owner on Oct 11, 2023. It is now read-only.

Mobile gameapp #235

Merged
merged 16 commits into from
May 13, 2021
Merged

Mobile gameapp #235

merged 16 commits into from
May 13, 2021

Conversation

JustinPinero
Copy link
Contributor

Restyled Gameapp render properly on mobile. Added a drawer feature for sidebar to render.

image

image

image

image

image

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 12, 2021
@JustinPinero JustinPinero requested a review from JackUrb May 12, 2021 07:51
Copy link
Contributor

@JackUrb JackUrb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall this is great! Definitely looking forward to giving it a try on mobile.

My only concern is that the button at the moment feels like a title - it could be nice to have both profile and game up at the top always, and toggling changes which is 'active'. Can be addressed in a follow-up though


.controls span.action {
}
*/ .controls span.action {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm having trouble following what is commented out in this file.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh good catch, that looks like a typo because I was only commenting out the names of sections so when I break them down easier that would be done. So I made a mistake here. I will fix that now. I will definitely fine tune the drawer.

@JustinPinero
Copy link
Contributor Author

Overview
I fixed alignment and size issues in Chat:

  1. Chat bubbles.
  2. Chat bubble icons (reply, report, award)
  3. Character Name Plates.
    I built out Mobile frame such that the sidebar will now "slide" over the chat app in mobile using a toggle in the head of the frame. The chat in mobile will size appropriately with any device and the sections of the chat (chatlog, input bar, and speech bubble container) will all size appropriately as well. Speech Bubbles' tail will now scale appropriately. Text in all the entry types now scales appropriately as well.

image

image

image

Testing
Tested the app across multiple device simulations using the browser's dev tools and the content looks as it should.

@JustinPinero JustinPinero requested a review from JackUrb May 13, 2021 21:09
Copy link
Contributor

@JackUrb JackUrb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's get this up and running!

@JustinPinero JustinPinero merged commit 0225c65 into mobile-restyling May 13, 2021
@JackUrb
Copy link
Contributor

JackUrb commented May 13, 2021

As a follow-up, the toggle could have labeling as to the Game being the default state and Profile + Character Details being the other state, but I'm not sold that Profile + Character Details is actually what we're putting in the other pane, and would rather just be functional.

@JackUrb JackUrb deleted the mobile-gameapp branch May 13, 2021 21:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants