-
Notifications
You must be signed in to change notification settings - Fork 5
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall this is great! Definitely looking forward to giving it a try on mobile.
My only concern is that the button at the moment feels like a title - it could be nice to have both profile and game up at the top always, and toggling changes which is 'active'. Can be addressed in a follow-up though
deploy/web/gameapp/src/styles.css
Outdated
|
||
.controls span.action { | ||
} | ||
*/ .controls span.action { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm having trouble following what is commented out in this file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh good catch, that looks like a typo because I was only commenting out the names of sections so when I break them down easier that would be done. So I made a mistake here. I will fix that now. I will definitely fine tune the drawer.
…ilding MobileFrame component
Overview
Testing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's get this up and running!
As a follow-up, the toggle could have labeling as to the |
Restyled Gameapp render properly on mobile. Added a drawer feature for sidebar to render.