This repository has been archived by the owner on Oct 11, 2023. It is now read-only.
Status entry #230
Merged
Status entry #230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
JackUrb
approved these changes
May 10, 2021
Comment on lines
+46
to
+47
| } | ||
| if (msg.caller == "HealthEvent") { |
There was a problem hiding this comment.
Nit: control flow here is probably clearer with explicit else if
JackUrb
suggested changes
May 10, 2021
There was a problem hiding this comment.
After seeing the inventory version, I think I have an idea as to what could be improved on these stylistically:
Can we have these images as backdrops inside of a text box? Looking for an example right now, but it could be a text box with similar dimensions to these images (plus some padding), and the text appears on top to use the real-estate better?
|
Here's the revised entry |
JackUrb
approved these changes
May 11, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Added styles to status entry.
Tests
Properly rendered player stats and entry was responsive.