Skip to content
This repository has been archived by the owner on Oct 11, 2023. It is now read-only.

added help entry #223

Merged
merged 2 commits into from
May 5, 2021
Merged

added help entry #223

merged 2 commits into from
May 5, 2021

Conversation

JustinPinero
Copy link
Contributor

Help entry will render with HelpEvent caller.
image

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 5, 2021
@JustinPinero JustinPinero requested a review from JackUrb May 5, 2021 19:27
JackUrb
JackUrb approved these changes May 5, 2021
View reviewed changes
Copy link
Contributor

@JackUrb JackUrb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Definitely looks nicer this way 😄

@JustinPinero JustinPinero merged commit 1bce452 into master May 5, 2021
@JackUrb JackUrb deleted the help-entry branch May 5, 2021 20:33
@jaseweston
Copy link
Contributor

Yes looks much nicer!
I think there's some end quotes missing though on the say/shout line? oh i guess that's not right in the original help message...

say/shout ""; or use quotes only for short ""

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JackUrb JackUrb JackUrb approved these changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@JustinPinero @jaseweston @JackUrb @facebook-github-bot