This repository has been archived by the owner on Nov 21, 2023. It is now read-only.
Warn users when eval is skipped #624
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rbgirshick @ir413 Why not merging this one ? |
There was a problem hiding this comment.
rbgirshick has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
Hi @gadcam, can you format the warning messages so that the line length is <= 88 characters (80 chars + 10% slack)? Thanks. |
|
Hi @rbgirshick |
rbgirshick
reviewed
Aug 31, 2018
There was a problem hiding this comment.
rbgirshick has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
xzhewei
pushed a commit
to xzhewei/Detectron
that referenced
this pull request
Jan 10, 2019
Summary: Fix for facebookresearch#620 & facebookresearch#293. Pull Request resolved: facebookresearch#624 Reviewed By: ir413 Differential Revision: D9574052 Pulled By: rbgirshick fbshipit-source-id: f44cea71e5cf6e613d319322db62a60ecb814a75
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #620 & #293.