Add more test method in Filter::AlwaysFalse class #9718
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
✅ Deploy Preview for meta-velox canceled.
|
Yuhta
approved these changes
May 6, 2024
Yuhta
added
the
ready-to-merge
|
@bikramSingh91 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
xiaoxmeng
reviewed
May 7, 2024
| @@ -312,6 +312,10 @@ class AlwaysFalse final : public Filter { | |||
| return false; | |||
| } | |||
|
|
|||
| bool testNull() const final { | |||
There was a problem hiding this comment.
Shall we add tests for these methods? Thanks!
There was a problem hiding this comment.
I would say this is too trivial to be tested
Yuhta
approved these changes
May 8, 2024
|
@bikramSingh91 merged this pull request in f536875. |
|
Conbench analyzed the 1 benchmark run on commit There were no benchmark performance regressions. 🎉 The full Conbench report has more details. |
Joe-Abraham
pushed a commit
to Joe-Abraham/velox
that referenced
this pull request
Jun 7, 2024
…9718) Summary: We now use alwaysFalse of Filter.h and some method not implemented causing runtime error. So, we'd like to implment some alwaysFalse method to avoid the error. Pull Request resolved: facebookincubator#9718 Reviewed By: Yuhta Differential Revision: D57072475 Pulled By: bikramSingh91 fbshipit-source-id: a8986387f044cdf6f21096d06c5fdfc070aba09a
Joe-Abraham
pushed a commit
to Joe-Abraham/velox
that referenced
this pull request
Jun 7, 2024
…9718) Summary: We now use alwaysFalse of Filter.h and some method not implemented causing runtime error. So, we'd like to implment some alwaysFalse method to avoid the error. Pull Request resolved: facebookincubator#9718 Reviewed By: Yuhta Differential Revision: D57072475 Pulled By: bikramSingh91 fbshipit-source-id: a8986387f044cdf6f21096d06c5fdfc070aba09a
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We now use alwaysFalse of Filter.h and some method not implemented causing runtime error. So, we'd like to implment some alwaysFalse method to avoid the error.