Add DynamicRowView and its reader #5075
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for meta-velox canceled.
|
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D46299159 |
laithsakka
added a commit
to laithsakka/velox
that referenced
this pull request
May 30, 2023
Summary: Pull Request resolved: facebookincubator#5075 A DynamicRowView can represent a row vector of any width of any types, without having to be typed. It has two functions: 1. size() : width of the struct. 2. at(int i) : return generic view for the field i. This simplify and enable writing functions with rows of unknown or unlimited types. This is also needed to support row types in the GenericWriter copy_from operation. next diff will plug DynamicRowView and DynamicRowWriter in the simple function interface and then row support for generic writer copy_from operation will be added. Differential Revision: D46299159 fbshipit-source-id: 6380cee1ce487664f727cba3d485adf629ead46d
laithsakka
force-pushed
the
export-D46299159
branch
from
c67e6a2 to
ff4fef5
Compare
|
This pull request was exported from Phabricator. Differential Revision: D46299159 |
laithsakka
added a commit
to laithsakka/velox
that referenced
this pull request
May 31, 2023
Summary: Pull Request resolved: facebookincubator#5075 A DynamicRowView can represent a row vector of any width of any types, without having to be typed. It has two functions: 1. size() : width of the struct. 2. at(int i) : return generic view for the field i. This simplify and enable reading vectors of rows with unknown or unlimited types. This is also needed to support row types in the GenericWriter copy_from operation. This can't be used in the simple function interface as top level because our function signature does not support it but it generics can be casted to it. It is needed to enable row support in generic writer copy_from operation will be added. Differential Revision: D46299159 fbshipit-source-id: d54e6dc6405ddbdfc6a252a0d028c864278485ff
laithsakka
force-pushed
the
export-D46299159
branch
from
ff4fef5 to
1d2d29d
Compare
|
This pull request was exported from Phabricator. Differential Revision: D46299159 |
Summary: Pull Request resolved: facebookincubator#5075 A DynamicRowView can represent a row vector of any width of any types, without having to be typed. It has two functions: 1. size() : width of the struct. 2. at(int i) : return generic view for the field i. This simplify and enable reading vectors of rows with unknown or unlimited types. This is also needed to support row types in the GenericWriter copy_from operation. This can't be used in the simple function interface as top level because our function signature does not support it but it generics can be casted to it. It is needed to enable row support in generic writer copy_from operation will be added. Reviewed By: kevinwilfong, kagamiori Differential Revision: D46299159 fbshipit-source-id: 41ba4d49197f9f71e66f13157175ef79f4efba2f
laithsakka
force-pushed
the
export-D46299159
branch
from
1d2d29d to
05ed1ee
Compare
|
This pull request was exported from Phabricator. Differential Revision: D46299159 |
|
This pull request has been merged in 7f43495. |
|
Conbench analyzed the 1 benchmark run on commit There were no benchmark performance regressions. 🎉 The full Conbench report has more details. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
A DynamicRowView can represent a row vector of any width of any types, without having to be typed.
It has two functions:
This simplify and enable writing functions with rows of unknown
or unlimited types. This is also needed to support row types
in the GenericWriter copy_from operation.
next diff will plug DynamicRowView and DynamicRowWriter in the
simple function interface and then row support for generic writer
copy_from operation will be added.
Differential Revision: D46299159