Address comments for D30917653 #210
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D30941572 |
OswinC
force-pushed
the
export-D30941572
branch
from
ee3abf0 to
1dc0ebe
Compare
|
This pull request was exported from Phabricator. Differential Revision: D30941572 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D30941572 |
OswinC
force-pushed
the
export-D30941572
branch
from
1dc0ebe to
12d5d12
Compare
Summary: Pull Request resolved: facebookincubator/velox#210 Title. Address comments by funrollloops Reviewed By: funrollloops Differential Revision: D30941572 fbshipit-source-id: f78fcb30896de0be7706b29978006316d82980bd
OswinC
force-pushed
the
export-D30941572
branch
from
12d5d12 to
33b2d97
Compare
|
This pull request was exported from Phabricator. Differential Revision: D30941572 |
|
This pull request has been merged in 757d64a. |
rui-mo
added a commit
to rui-mo/velox
that referenced
this pull request
Mar 17, 2023
rui-mo
pushed a commit
to rui-mo/velox
that referenced
this pull request
Apr 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Title. Address comments by funrollloops
Differential Revision: D30941572