Fix JSON parser to allow control characters in JSON string input #11433
+30
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JSON string input can contain control characters, e.g., new line character
\n
. It can becorrectly handled by Presto, but not allowed by simdjson lib. If it exists in input, simdjson
will return
UNESCAPED_CHARS
error, then Velox will output null. Simdjson only allows literal\n
(represented by\\n
). See its code link.Here is a test result with presto.
Just created one discussion thread in simdjson community: simdjson/simdjson#2287.