Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle UNKNOWN type input in approx_distinct #11367

Closed
wants to merge 1 commit into from

Conversation

Yuhta
Copy link
Contributor

@Yuhta Yuhta commented Oct 28, 2024

Reviewed By: amitkdutta

Differential Revision: D65100134

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 28, 2024
Copy link

netlify bot commented Oct 28, 2024

Deploy Preview for meta-velox canceled.

Name Link
🔨 Latest commit ffda59a
🔍 Latest deploy log https://app.netlify.com/sites/meta-velox/deploys/672a4881e252770008dd83ec

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D65100134

Yuhta added a commit to Yuhta/velox that referenced this pull request Oct 29, 2024
Summary: Pull Request resolved: facebookincubator#11367

Reviewed By: amitkdutta

Differential Revision: D65100134
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D65100134

Yuhta added a commit to Yuhta/velox that referenced this pull request Oct 29, 2024
Summary: Pull Request resolved: facebookincubator#11367

Reviewed By: amitkdutta

Differential Revision: D65100134
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D65100134

Yuhta added a commit to Yuhta/velox that referenced this pull request Oct 29, 2024
Summary:
bypass-github-export-checks

Reviewed By: amitkdutta

Differential Revision: D65100134
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D65100134

Yuhta added a commit to Yuhta/velox that referenced this pull request Oct 30, 2024
…acebookincubator#11367)

Summary: Pull Request resolved: facebookincubator#11367

Reviewed By: amitkdutta

Differential Revision: D65100134
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D65100134

…acebookincubator#11367)

Summary: Pull Request resolved: facebookincubator#11367

Reviewed By: amitkdutta

Differential Revision: D65100134
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D65100134

@facebook-github-bot
Copy link
Contributor

This pull request has been merged in 415f14e.

Copy link

Conbench analyzed the 1 benchmark run on commit 415f14e1.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants