-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update FBOS to v2024.07.01 #11104
Update FBOS to v2024.07.01 #11104
Conversation
✅ Deploy Preview for meta-velox canceled.
|
4bd713b
to
f2045b7
Compare
f2045b7
to
d40111b
Compare
@majetideepak My adapters image still has issues with the GCS tests but I think we can show that upgrading FBOS works fine as everything else passes. Turns out the way I built the adapter container can't set the right conda environment and it just installs the testbench to the default env.
which then results in the gcs test failure due to the missing pip dependency of testbench
|
a5bcddf
to
05db195
Compare
@majetideepak @assignUser Please review. I will remove the last commit that changes the adapter images that used the new folly version now that we had a clean run. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @czentgr.
I will add the merge tag once the last commit has been removed. |
05db195
to
63ece32
Compare
@xiaoxmeng has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
63ece32
to
168ba3e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @czentgr
@xiaoxmeng merged this pull request in 3fabdf5. |
Conbench analyzed the 1 benchmark run on commit There were no benchmark performance regressions. 🎉 The full Conbench report has more details. |
No description provided.