Move fileformat's config setting into HiveConnectorUtils #10915
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
✅ Deploy Preview for meta-velox canceled.
|
|
@xiaoxmeng Can you help to review this PR? Thanks. |
JkSelf
force-pushed
the
writer-config-refactor
branch
2 times, most recently
from
6121072
to
868d253
Compare
JkSelf
force-pushed
the
writer-config-refactor
branch
from
868d253
to
a6d2f6e
Compare
JkSelf
force-pushed
the
writer-config-refactor
branch
from
a6d2f6e
to
0c5c81d
Compare
xiaoxmeng
approved these changes
Sep 4, 2024
|
@xiaoxmeng has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Yuhta
reviewed
Sep 4, 2024
| namespace { | ||
|
|
||
| #ifdef VELOX_ENABLE_PARQUET | ||
| std::optional<TimestampUnit> getTimestampUnit( |
There was a problem hiding this comment.
getTimestampUnit and getTimestampTimeZone is not parquet specific
There was a problem hiding this comment.
@Yuhta Thanks for your catch. It should be VELOX_ENABLE_ARROW. I have updated. Can you help to review again? Thanks.
There was a problem hiding this comment.
@Yuhta It seems we still need to use VELOX_ENABLE_PARQUET here. Otherwise the build will failed with following exceptions:
error: ‘getTimestampUnit’ was not declared in this scope; did you mean ‘TimestampUnit’?
JkSelf
force-pushed
the
writer-config-refactor
branch
2 times, most recently
from
a1a9d01
to
3e10282
Compare
|
@xiaoxmeng merged this pull request in 1900d60. |
|
Conbench analyzed the 1 benchmark run on commit There were no benchmark performance regressions. 🎉 The full Conbench report has more details. |
Yuhta
added a commit
to Yuhta/velox
that referenced
this pull request
Sep 6, 2024
Summary: Recent refactor facebookincubator#10915 breaks the capability to write to Nimble table in Hive connector, fix it. Differential Revision: D62302602
Yuhta
added a commit
to Yuhta/velox
that referenced
this pull request
Sep 6, 2024
Summary: Pull Request resolved: facebookincubator#10941 Recent refactor facebookincubator#10915 breaks the capability to write to Nimble table in Hive connector, fix it. Reviewed By: xiaoxmeng Differential Revision: D62302602
Yuhta
added a commit
to Yuhta/velox
that referenced
this pull request
Sep 6, 2024
Summary: Pull Request resolved: facebookincubator#10941 Recent refactor facebookincubator#10915 breaks the capability to write to Nimble table in Hive connector, fix it. Reviewed By: xiaoxmeng Differential Revision: D62302602
Yuhta
added a commit
to Yuhta/velox
that referenced
this pull request
Sep 9, 2024
Summary: Pull Request resolved: facebookincubator#10941 Recent refactor facebookincubator#10915 breaks the capability to write to Nimble table in Hive connector, fix it. Reviewed By: xiaoxmeng Differential Revision: D62302602
Yuhta
added a commit
to Yuhta/velox
that referenced
this pull request
Sep 9, 2024
Summary: Pull Request resolved: facebookincubator#10941 Recent refactor facebookincubator#10915 breaks the capability to write to Nimble table in Hive connector, fix it. Reviewed By: xiaoxmeng Differential Revision: D62302602
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor the config setting logic from fileformat's writer to HiveConnectorUtils.