Skip to content

Commit

Permalink
[antlir] remove warning about resources not being executable
Browse files Browse the repository at this point in the history
Summary:
There's little value in logging this, and users easily get confused thinking
it's an error.

Test Plan: testhard

Reviewed By: justintrudell

Differential Revision: D51166685

fbshipit-source-id: 0f9cd7642257833f9dcaed4d6003d8259d8cdc26
  • Loading branch information
vmagro authored and facebook-github-bot committed Nov 10, 2023
1 parent 077d68f commit f1a29ea
Showing 1 changed file with 3 additions and 5 deletions.
8 changes: 3 additions & 5 deletions antlir/fs_utils.py
Original file line number Diff line number Diff line change
Expand Up @@ -376,13 +376,11 @@ def resource(cls, package, name: str, *, exe: bool) -> Iterator["Path"]:
yield Path(rsrc_in.name).abspath()
return

# why does this happen? who knows but we can make a copy of
# the binary that _is_ executable
log.warning(
f"{package}.{name} doesn't exist or is not executable"
) # pragma: no cover
# The resource has no path, so we have to materialize it.
#
# Why does this happen? Who knows - but we can make a copy of the
# binary that _is_ executable and antlir1 limps on another day.
#
# This code path is not reached by our coverage harness,
# since resources in '@mode/dev will always have a real
# filesystem path. However, we get all the needed signal
Expand Down

0 comments on commit f1a29ea

Please sign in to comment.