Skip to content

Commit

Permalink
[antlir2][install] fix trailing comma introduced by D49195669
Browse files Browse the repository at this point in the history
Summary:
This turns it into a tuple which then breaks later on.

If only TD was working and actually tested our builds on that diff...

Test Plan:
```
❯ buck2 build --show-output fbcode//netos/services/fboss_qsfp_service:netos.service.fboss_qsfp_service.x86_64--layer
Buck UI: https://www.internalfb.com/buck2/9bf4cd93-9a5f-4843-947f-71404e846b15
Network: Up: 0B  Down: 472MiB  (reSessionID-dec19fa3-4155-41e5-8fd9-970a9813d364)
Jobs completed: 158667. Time elapsed: 11.4s.
BUILD SUCCEEDED
fbcode//netos/services/fboss_qsfp_service:netos.service.fboss_qsfp_service.x86_64--layer buck-out/v2/gen/fbcode/f3a0a1b7a89acbb0/netos/services/fboss_qsfp_service/__netos.service.fboss_qsfp_service.x86_64--layer__/subvol-compile_compile
```

Reviewed By: sergeyfd

Differential Revision: D49918309

fbshipit-source-id: 09f2ca48ffb1370849cfc271ca70b5a0a81338c7
  • Loading branch information
vmagro authored and facebook-github-bot committed Oct 4, 2023
1 parent aa02ce2 commit de4ef5d
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions antlir/antlir2/bzl/feature/install.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
# This source code is licensed under the MIT license found in the
# LICENSE file in the root directory of this source tree.

load("//antlir/antlir2/bzl:debuginfo.bzl", "SplitBinaryInfo", "split_binary_anon")
load("//antlir/antlir2/bzl:debuginfo.bzl", "split_binary_anon")
load("//antlir/antlir2/bzl:macro_dep.bzl", "antlir2_dep")
load("//antlir/antlir2/features:defs.bzl", "FeaturePluginInfo")
load("//antlir/buck2/bzl:ensure_single_output.bzl", "ensure_single_output")
Expand Down Expand Up @@ -155,7 +155,7 @@ def get_feature_anaylsis_for_install(
),
)
required_artifacts.extend([binary_info.installed.debuginfo, binary_info.installed.metadata])
src = split_anon_target.artifact("src"),
src = split_anon_target.artifact("src")
else:
src = ensure_single_output(src)
binary_info = None
Expand Down

0 comments on commit de4ef5d

Please sign in to comment.